Simplify nodejs client and wallet #1119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r/iota-sdk into chore/bindings-cleanup
thibault-martinez
changed the title
added 5 commits
September 7, 2023 09:51
* unify error handling and responses * wasm * its something * secret manager alignment * error on callback fix * listen error in wasm, madelisten async again
kwek20
previously approved these changes
Sep 7, 2023
kwek20
previously approved these changes
Sep 7, 2023
Thoralf-M
commented
Sep 7, 2023
kwek20
previously approved these changes
Sep 11, 2023
DaughterOfMars
requested changes
Sep 11, 2023
If you just mean the Error("") vs "", i can change that and add a todo? Sync methods can also be awaited, so user code doesnt change |
@kwek20 @DaughterOfMars any update on this? |
|
I don't know if that statement is true but even if it is I don't really like the changes that were made |
|
The statement is true :) lets merge. at the very least its cleaner than current code. can always opt not to close the issue. |
|
What's the status of this PR btw? |
|
Waiting for @kwek20 to rebase it on 2.0 |
|
closed in favour of the 2.0 PR |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR cleans up the client and wallet nodejs rust bindings.
Links to any relevant issues
Closes #699
Replaces #1056